Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateSitePublisher -addJREIU argument doesn't add current JVM #461

Closed
iloveeclipse opened this issue Feb 12, 2024 · 1 comment · Fixed by #462
Closed

UpdateSitePublisher -addJREIU argument doesn't add current JVM #461

iloveeclipse opened this issue Feb 12, 2024 · 1 comment · Fixed by #462
Assignees
@iloveeclipse
Labels
bug Something isn't working
Milestone
4.31 M3

Comments

@iloveeclipse
Copy link
Member

One of the issues found while investigating #450.

eclipse -application org.eclipse.equinox.p2.publisher.UpdateSitePublisher -addJREIU ... doesn't add JRE "IU" for the currently used JRE but to the one set in JREAction.DEFAULT_PROFILE (currently Java 17).

So I'm unable to add "a.jre.javase" with Java 21 to the published update site content.xml and so can't install bundles that require Java 21 using plain SDK, even if everything runs on Java 21.
@iloveeclipse iloveeclipse added the bug Something isn't working label Feb 12, 2024
@iloveeclipse iloveeclipse mentioned this issue Feb 12, 2024
Closed
iloveeclipse added a commit to iloveeclipse/p2 that referenced this issue Feb 12, 2024
@iloveeclipse
UpdateSitePublisher -addJREIU argument doesn't add current JVM
1a782bb 
Don't hard code "default" JRE version if we "guess one" and create some
profile based on current JRE packages. Just read & use the version from
the running JRE.

Fixes eclipse-equinox#461
@iloveeclipse iloveeclipse mentioned this issue Feb 12, 2024
Merged
iloveeclipse added a commit to iloveeclipse/p2 that referenced this issue Feb 12, 2024
@iloveeclipse
UpdateSitePublisher -addJREIU argument doesn't add current JVM
8cd02b9 
Don't hard code "default" JRE version if we "guess one" and create some
profile based on current JRE packages. Just read & use the version from
the running JRE.

Fixes eclipse-equinox#461
iloveeclipse added a commit to iloveeclipse/p2 that referenced this issue Feb 12, 2024
@iloveeclipse
UpdateSitePublisher -addJREIU argument doesn't add current JVM
b5f1716 
Don't hard code "default" JRE version if we "guess one" and create some
profile based on current JRE packages. Just read & use the version from
the running JRE.

Fixes eclipse-equinox#461
@iloveeclipse iloveeclipse self-assigned this Feb 12, 2024
@iloveeclipse iloveeclipse added this to the 4.31 M3 milestone Feb 12, 2024
@iloveeclipse
Copy link
Member Author

Verified works with I20240212-1800. I can generate "a.jre.javase" 21 IU now via UpdateSitePublisher application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
bug Something isn't working
Projects
None yet
Milestone
4.31 M3
Development

Successfully merging a pull request may close this issue.

UpdateSitePublisher -addJREIU argument doesn't add current JVM iloveeclipse/p2
1 participant
@iloveeclipse