[Build] Replace use of coactions/setup-xvfb #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurtakov
force-pushed
the
master
branch
5 times, most recently
from
48648ce to
56c2d1d
Compare
|
@akurtakov I just pushed an update that should fix the failures and also restores the previous step order. Not that the order is important in that case, but I think we should minimize changes. |
HannesWell
changed the title
|
Something is still wrong with Windows. |
The problem seems to be that powershell(-core), which is the default shell on Windows runners seems to interpret dots in variables differently. To solve this we would either have to escape all arguments that contain a dot or use cmd as shell. |
It will stop working on Oct 15 and is claimed to not be needed anymore. Co-authored-by: Hannes Wellmann <[email protected]>
|
Finally all builds have been successful without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will stop working on Oct 15 and is claimed to not be needed anymore in coactions/setup-xvfb#29 (comment)