-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage OSGi-DS component-xml file generation of PDE-DS/Tycho #661
base: master
Are you sure you want to change the base?
Leverage OSGi-DS component-xml file generation of PDE-DS/Tycho #661
Conversation
Test Results 660 files + 660 660 suites +660 1h 2m 3s ⏱️ + 1h 2m 3s For more details on these errors, see this check. Results for commit f320256. ± Comparison against base commit 773fe39. ♻️ This comment has been updated with latest results. |
a80557c
to
6aa7046
Compare
The |
6aa7046
to
4e75c19
Compare
Yes, see #662. Although the test failure was in equinox.ds.tests. |
1b665b3
to
04225a0
Compare
I really don't understand why the test is failing. |
@@ -1 +1,2 @@ | |||
/scr_test | |||
OSGI-INF/org.eclipse.equinox.*.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSGI-INF/org.eclipse.equinox.*.xml | |
OSGI-INF/*.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reduced it now to OSGI-INF/org.eclipse.*.xml
, but ignoring all XML could be too restrictive. And since in the fast majority of cases the classes in eclipse projects are in a org.eclipse...
package this should be fine. And if not, one will notice it quickly and can adjust the pattern in that specific case.
I assume the problem is that the bundle is not packed before executed as a test and then the launcher looks for |
04225a0
to
ddfd814
Compare
Yes. :/ |
ddfd814
to
bfbe06d
Compare
bfbe06d
to
2de4b41
Compare
Remove generated xml-files from equinox.ds.tests.
2de4b41
to
f320256
Compare
Remove all generated xml-files from git.
Especially the component-xml files are annoying since the state in git is not up to date. Consequently they are changed on each build and make the git staging dirty.
See https://gitlab.eclipse.org/eclipse-wg/ide-wg/community/-/issues/47#note_2617895