-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated core.launcher.Main and equinox.launcher.WebStartMain #562
Remove deprecated core.launcher.Main and equinox.launcher.WebStartMain #562
Conversation
5ad1c17
to
f035f2f
Compare
Lets proceed with deleting this. |
Great. But there is a surprising number of references in code to that launcher in the SDK that have to be migrated first:
The references in PDE look fine since they handle old target-platforms that probably didn't include the 'new' class. |
Thanks for finding these. It is good to get them updated to the new class. |
7a6f3fb
to
dc5176d
Compare
Both classes have been deprecated over five years ago via https://bugs.eclipse.org/bugs/show_bug.cgi?id=544262
dc5176d
to
c08d455
Compare
Your welcome and yes, absolutely. I guess they were simply not discovered since the class was only referenced by its name. Now that we had a new I-build with all the remaining references replaced (where suitable) and the CI builds passed I think we can finally submit this. |
Looks like this removal went fine and didn't blow up the world. The I-build test results look like before: |
Both classes have been deprecated over five years ago via https://bugs.eclipse.org/bugs/show_bug.cgi?id=544262.
There have been requests to keep the classes four years ago in https://bugs.eclipse.org/bugs/show_bug.cgi?id=544262#c29, but as far as I can tell there have been no contribution of the requested tests?
@tjwatson should we proceed with the removal or ask again for feedback? If there are still real users out there, they can still maintain the code by themself. Since they are using WebStart in some way they can probably even test it better than Equinox can do, if there are really no tests.