Enabling MacOS launcher artifacts testing in github workflows

[umairsair]

Relates to eclipse-equinox/p2#166

[github-actions]

Test Results

   28 files  + 1     28 suites  +1   11m 29s ⏱️ -12s
2 170 tests ± 0  2 124 ✅ ± 0  46 💤 ±0  0 ❌ ±0 
2 242 runs  +14  2 196 ✅ +14  46 💤 ±0  0 ❌ ±0 

Results for commit 53da656. ± Comparison against base commit a90f8b5.

♻️ This comment has been updated with latest results.

[umairsair]

@sravanlakkimsetti kindly review.. MacOS testing was the missing bit in github workflows from launcher perspective and I have added that.. no binary updates required because of this PR..

[sravanlakkimsetti]

@subyssurendran666 Can you please take a look at this one?

[laeubi]

I noticed on some PRs that the Build Equinox / build-launcher-mac64 is often failing see for example:
https://github.com/eclipse-equinox/equinox/actions/runs/7810176950/job/21303190211?pr=504

will this be fixed here as well?

[subyssurendran666]

Sure @sravanlakkimsetti

[laeubi]

@subyssurendran666 @sravanlakkimsetti can we please finish this? currently the mac build always fails and this seems to fix it.

As this only affects the github verification I would give +1 as PL for merging this even in freeze period if not @tjwatson has any concerns.

[sravanlakkimsetti]

I noticed on some PRs that the Build Equinox / build-launcher-mac64 is often failing see for example: https://github.com/eclipse-equinox/equinox/actions/runs/7810176950/job/21303190211?pr=504

will this be fixed here as well?

the fix for this is to remove this line

equinox/features/org.eclipse.equinox.executable.feature/library/cocoa/build.sh

Line 101 in 841faf8

make -f $makefile install

. This line copies built artifacts to binaries repo, which does not exist during the validation runs. This copying part is not there for windows and linux. We can safely remove this line.

For the code changes I approved this change.