Migrate debugoptions, hooks and resources in o.e.osgi.tests to JUnit 4 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
junit4-debugoptions_hooks_resources
branch
from
954b2e1 to
671d012
Compare
HannesWell
reviewed
Dec 21, 2023
...les/org.eclipse.osgi.tests/src/org/eclipse/osgi/tests/debugoptions/DebugOptionsTestCase.java
Outdated
Show resolved
Hide resolved
...les/org.eclipse.osgi.tests/src/org/eclipse/osgi/tests/debugoptions/DebugOptionsTestCase.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.osgi.tests/src/org/eclipse/osgi/tests/resource/BasicTest.java
Outdated
Show resolved
Hide resolved
HannesWell
force-pushed
the
junit4-debugoptions_hooks_resources
branch
from
671d012 to
cbc12df
Compare
This migrates all tests in org.eclipse.osgi.tests.debugoptions, org.eclipse.osgi.tests.hooks.framework and org.eclipse.osgi.tests.resource to JUnit 4 * Add JUnit 4 annotations @test, @before, @after * Remove inheritance of JUnit 3 TestCase and CoreTest * Replace try-catch for actual errors with making the test method throw the exception
HeikoKlare
force-pushed
the
junit4-debugoptions_hooks_resources
branch
from
cbc12df to
752ffd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates all tests in
org.eclipse.osgi.tests.debugoptions,org.eclipse.osgi.tests.hooks.frameworkandorg.eclipse.osgi.tests.resourceto JUnit 4@Test,@Before, @After`