Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to lambda in o.e.osgi #439

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

akurtakov
Copy link
Member

No description provided.

@akurtakov
Copy link
Member Author

Yet another iteration on eclipse-platform/eclipse.platform.releng.aggregator#1659

Copy link

Test Results

     24 files  ±0       24 suites  ±0   10m 39s ⏱️ ±0s
2 150 tests ±0  2 105 ✔️ ±0  45 💤 ±0  0 ±0 
2 194 runs  ±0  2 149 ✔️ ±0  45 💤 ±0  0 ±0 

Results for commit 33adea0. ± Comparison against base commit bf62833.

@akurtakov akurtakov merged commit 45c1d7c into eclipse-equinox:master Dec 15, 2023
22 of 25 checks passed
@HannesWell
Copy link
Member

In the past (pre GitHub time) I did similar clean-ups in a broader scope but it had to be reverted because it led to a worse performance on Java 8 which was not acceptable for @tjwatson.

I think a single place doesn't hurt much, but if done on more places it could become relevant again. :/

@tjwatson
Copy link
Contributor

These look fine. They are low traffic calls so I don't expect it to impact performance much.

For the record, it seemed that the JIT compiler could not optimize the lambda reference nearly as much as the anonymous class. I don't remember the specific details but was told by the Java team that they do expect the JIT to get better in that regards at some point, but I do not think it has gotten up to the optimizations of anonymous class compilation speeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants