Move equinox.common/registry/app/preferences and dependents to Java-17 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
java17-migration
branch
from
d28004e to
02d7411
Compare
|
These are the ones I need to stay at Java 8:
|
HannesWell
force-pushed
the
java17-migration
branch
from
02d7411 to
6632e58
Compare
Thanks for the list. I left those bundles untouched plus the following ones
All other bundles, including all tests now require Java-17. For the tests I think a lower java requirement is not necessary since the tests run in the CI with Java-17 anyways. |
HannesWell
force-pushed
the
java17-migration
branch
3 times, most recently
from
7b77d96 to
8d52e25
Compare
|
manual rebase is needed |
Even if the tested bundle still required Java-1.8 its test bundle can require Java-17 since in the CI Java-17 is used anyways to run it.
HannesWell
force-pushed
the
java17-migration
branch
from
8d52e25 to
0455bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migrated plugins are all projects in equinox that are currently on Java-11.
@tjwatson I hope none of these plugins is one of the ones you want to keep at Java-1.8.
Could you please list the projects that should stay at JavaSE-1.8?
I only recall org.eclipse.osgi for sure, but I think not all of those that are currently at 1.8 need to stay there and could be migrated to Java-17 as well?