Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jakarta.servlet-api, javax.servlet.jsp-api, javax.el-api #387

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 23, 2023

These bundles are included by features but are not actually needed at runtime.

eclipse-platform/eclipse.platform.releng.aggregator#1361

These bundles are included by features but are not actually needed at
runtime.

eclipse-platform/eclipse.platform.releng.aggregator#1361
@github-actions
Copy link

Test Results

     24 files  ±0       24 suites  ±0   9m 34s ⏱️ +29s
2 150 tests ±0  1 993 ✔️ ±0  45 💤 ±0  0 ±0  112 🔥 ±0 
2 194 runs  ±0  2 037 ✔️ ±0  45 💤 ±0  0 ±0  112 🔥 ±0 

For more details on these errors, see this check.

Results for commit f328c69. ± Comparison against base commit 5b1f77f.

@merks
Copy link
Contributor Author

merks commented Oct 23, 2023

@akurtakov

Of course we have the same build/test problem.

Note though that the servlet tests pass:

image

Also, it looks like the only thing that test the jasper support are the ua tests:

image

So perhaps it's okay to be evil and press forward on this change as well?

@merks merks merged commit 7208dfa into eclipse-equinox:master Oct 23, 2023
@merks merks deleted the pr-remove-unused-includes branch October 23, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant