Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply project settings to o.e.equinox.http.servlet.tests #355

Conversation

Torbjorn-Svensson
Copy link
Contributor

  1. Convert to LF and ensure LF at EOF:
find . -type f -print0 | \
  xargs -r0 perl -le 'for (@argv) { print if -f && -T }' | \
  xargs -rd'\n' dos2unix -e
  1. Removed executable flag on files:
find . -type f -executable -print0 | \
  xargs -r0 chmod 644
  1. Format java files:
eclipse -consolelog -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter \
  -config .settings/org.eclipse.jdt.core.prefs . -data `mktemp -d`

@akurtakov akurtakov force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from 2dcf535 to d74a742 Compare November 3, 2023 08:10
Copy link

github-actions bot commented Nov 3, 2023

Test Results

   25 files  ±0     25 suites  ±0   10m 44s ⏱️ -1s
2 156 tests ±0  2 110 ✅ ±0  46 💤 ±0  0 ❌ ±0 
2 200 runs  ±0  2 154 ✅ ±0  46 💤 ±0  0 ❌ ±0 

Results for commit 3347ebb. ± Comparison against base commit e2267e3.

♻️ This comment has been updated with latest results.

@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from d74a742 to 62ca93a Compare November 3, 2023 18:05
@akurtakov
Copy link
Member

@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from 62ca93a to c5b7df1 Compare November 6, 2023 12:11
@Torbjorn-Svensson
Copy link
Contributor Author

This PR breaks tests https://ci.eclipse.org/equinox/job/equinox/job/PR-355/3/#showFailuresLink

I think I fixed all the failures with the last push.
I have some trouble running the test suite locally as my target platform does not appear to have the required jetty/jasper dependencies, but with some tweaks, I managed to get the ServletTest running in junit.
Let me know if there is more I should address.

@akurtakov akurtakov force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from c5b7df1 to 489ac90 Compare November 30, 2023 14:15
@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from 489ac90 to 16f519b Compare December 17, 2023 21:42
@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from 16f519b to 1057751 Compare January 6, 2024 18:22
@Torbjorn-Svensson
Copy link
Contributor Author

Rebased PR on 1d9eb47.
Anything I need to do prior to getting this merged?

@vogella
Copy link
Contributor

vogella commented Jan 15, 2024

@Torbjorn-Svensson this one has conflicts, please have a look

@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from 1057751 to d2c582b Compare January 15, 2024 08:55
@Torbjorn-Svensson
Copy link
Contributor Author

Something had went wrong in the last rebase so this PR accidentally included changes in another bundle. Corrected now and rebased on b297e05.

@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from d2c582b to 3ae622f Compare January 15, 2024 14:35
This was achieved by running:
find . -type f -print0 | \
  xargs -r0 perl -le 'for (@argv) { print if -f && -T }' | \
  xargs -rd'\n' dos2unix -e

Signed-off-by: Torbjörn SVENSSON <[email protected]>
This was achieved by running:
find . -type f -executable -print0 | \
  xargs -r0 chmod 644

Signed-off-by: Torbjörn SVENSSON <[email protected]>
This was achieved by running:
eclipse -consolelog -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter \
  -config .settings/org.eclipse.jdt.core.prefs . -data `mktemp -d`

Signed-off-by: Torbjörn SVENSSON <[email protected]>
@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/cleanup-o.e.equinox.http.servlet.tests branch from 3ae622f to 3347ebb Compare January 15, 2024 15:04
@vogella vogella merged commit 2776f8e into eclipse-equinox:master Jan 16, 2024
23 of 24 checks passed
@Torbjorn-Svensson Torbjorn-Svensson deleted the pr/cleanup-o.e.equinox.http.servlet.tests branch January 16, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants