Apply project settings to o.e.equinox.security.tests #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Torbjorn-Svensson
commented
Oct 1, 2023
Torbjorn-Svensson
commented
- Convert to LF and ensure LF at EOF:
- Format java files:
|
I think a few things need changing here.... |
...rity.tests/src/org/eclipse/equinox/internal/security/tests/storage/DetectPBECiphersTest.java
Outdated
Show resolved
Hide resolved
...uinox.security.tests/src/org/eclipse/equinox/internal/security/tests/storage/ManualTest.java
Show resolved
Hide resolved
|
@Torbjorn-Svensson can you update this one? |
Yes, but I would like your comment on my two questions :) |
|
No preference from my side, just decide based on your preference
Torbjorn-Svensson ***@***.***> schrieb am Mi., 18. Okt. 2023,
16:44:
… @Torbjorn-Svensson <https://github.com/Torbjorn-Svensson> can you update
this one?
Yes, but I would like your comment on my two questions :)
—
Reply to this email directly, view it on GitHub
<#342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCFBVYYHSPMZEU2K4WIE3X77TLJAVCNFSM6AAAAAA5OTDRSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYGYZDANRZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Torbjorn-Svensson I do not see an update from you. Do you plan to finish this one? |
I got slammed with other tasks the past 2 weeks. Last weekend, I started looking at why the TCKs failed in the other PRs, but never got to a point where I could actually see what test that was failing that previously was okay. |
This was achieved by running: find . -type f -print0 | \ xargs -r0 perl -le 'for (@argv) { print if -f && -T }' | \ xargs -rd'\n' dos2unix -e Signed-off-by: Torbjörn SVENSSON <[email protected]>
This was achieved by running: eclipse -consolelog -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter \ -config .settings/org.eclipse.jdt.core.prefs . -data `mktemp -d` Signed-off-by: Torbjörn SVENSSON <[email protected]>
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.equinox.security.tests
branch
from
5174d67 to
153af44
Compare
akurtakov
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.