Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly.yml #230

Closed
wants to merge 1 commit into from
Closed

Conversation

ojuschugh1
Copy link

Test the running generated project via Maven (e.g. call the REST endpoint) Test the running generated project via Docker

Test the running generated project via Maven (e.g. call the REST endpoint)
Test the running generated project via Docker
@eclipse-starter-bot
Copy link

Can one of the admins verify this patch?

@m-reza-rahman
Copy link
Contributor

Is this a draft PR that you are still working on? If so, please mark it as such. Otherwise, please open PRs that are complete, self-sufficient and add a specific value to the project. The PR in it's current form does not do that.

@ojuschugh1
Copy link
Author

i have added code to test -:
Test the running generated project via Maven (e.g. call the REST endpoint)
Test the running generated project via Docker
as addressed here More robust nightly build #185.

@m-reza-rahman
Copy link
Contributor

m-reza-rahman commented Mar 25, 2023

This is basically redundant code that does not actually do much. Please take the time to understand the project and how you may add meaningful tests. This is not a trivial task. It requires serious research and weeks or months of work.

@ojuschugh1
Copy link
Author

ok got it sir,Sorry for disturbing your time :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants