Fix for ReportQuery not fetching relationships with BatchFetch.IN #2303
Conversation
Sheikah45
force-pushed
the
batchfetchin
branch
4 times, most recently
from
48f6aaa to
911118d
Compare
Sheikah45
force-pushed
the
batchfetchin
branch
from
911118d to
9f2c06d
Compare
…rst field and batch size is hit
|
After some further testing I ran into the issue where the relationship was not populated when it was selected as not the first element in the Report Query and where the number of rows returned by the original query was greater than the batch size. This caused the foreignReferenceMapping to attempt to do an indexOf with the parent rows to find the starting index. However, the parent rows were the full row returned by the query but ReportQueryResult trimmed the database row that was passed to the ForeignReferenceMapping. Due to this the trimmed row didn't exist in the parent rows and so null was returned instead. For this reason I made it so that ReportQueryResult populates the trimmed rows as the parent row for the mappings specific to that item. But it could very well be the case that this is not the best approach and any input is welcome. It may also be a possibility that the an untrimmed row could be used as it looked like fields were used directly by ReportQueryResult to get the necessary data out of the DatabaseRecord but I was unsure if this was always the case and it wasn't clear why the trimmed row was being used in the first place. |
|
Additionally if there is a better place for the tests rather than their own app, let me know and I can move them to the appropriate location. |
No new Maven sub-project is fine. |
...ch/src/main/java/org/eclipse/persistence/jpa/testapps/batchfetch/BatchFetchTableCreator.java
Outdated
Show resolved
Hide resolved
...jpa.test.batchfetch/src/main/java/org/eclipse/persistence/jpa/testapps/batchfetch/Count.java
Outdated
Show resolved
Hide resolved
...pa.test.batchfetch/src/main/java/org/eclipse/persistence/jpa/testapps/batchfetch/Record.java
Outdated
Show resolved
Hide resolved
...lipselink.jpa.testapps/jpa.test.batchfetch/src/test/java/batchfetch/BatchFetchJUnitTest.java
Outdated
Show resolved
Hide resolved
|
Thank You |
|
Thanks, and just for information do you think this should be back ported? |
Please open PR against other branches. |
…lipse-ee4j#2303) (cherry picked from commit d7114a0)
…lipse-ee4j#2303) (cherry picked from commit d7114a0)
This PR includes the fix for #2011.
A ReportQuery was not populating the DataResults for it's batchFetchPolicy. This prevented the mapping from knowing what keys to use for the in query and always returned null instead.
For now it is just targeted to master, but I believe it can be backported as you see fit.