Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] fix #1950: Duplicate objects in UnitOfWorkImpl.primaryKeyToNewObjects - backport from master #1956

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

Zuplyx
Copy link
Contributor

@Zuplyx Zuplyx commented Oct 4, 2023

Backport of #1951 to 2.7. For details see PR to master.

- use IdentityHashSet instead of ArrayList for primaryKeyToNewObjects to prevent duplicates in the future
- added unit tests

Signed-off-by: Patrick Schmitt <[email protected]>
@rfelcman
Copy link
Contributor

rfelcman commented Oct 5, 2023

Just some note about failing eclipsefdn/eca check. It seems that e-mail address in the git Author doesn't match with sign-off footer.

Author: Patrick Schmitt <patrick_98@t*****.de>
Date:   Tue Oct 3 09:40:29 2023 +0200

......
......    
    Signed-off-by: Patrick Schmitt <Patrick.Schmitt@c****-s*****.com>

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 8d5a613 into eclipse-ee4j:2.7 Oct 5, 2023
4 checks passed
@Zuplyx Zuplyx deleted the 2.7_issue1950 branch October 5, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants