fix: working sample 04

[matthiasdg]

What this PR changes/adds

fixes #86; commands from README now work.

Why it does that

basically looked at transfer sample 01 and applied all dependencies/variables from there

Further notes

first experience with edc connector, so not sure if everything now behaves as it should. transfer happens + jaeger + prometheus work

Linked Issue(s)

Closes #86

Checklist

• performed checkstyle check locally?
• added/updated copyright headers?
• documented public classes/methods?
• documented code?
• assigned appropriate label?
• formatted title correctly? (take a look at the CONTRIBUTING for details) -> ENDS IN 404

[github-actions]

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

[ndr-brt]

Hey, thanks for the contribution, since you are here, could you take care on adding an integration test in the same way other samples are tested? so we'd avoid regressions in the future

[matthiasdg]

@ndr-brt to have an integration test that covers the differences with the transfer-01 sample requires including the docker-compose in the test.

As an experiment I did that, using the testcontainers framework. Note that running this test requires the downloaded opentelemetry-javaagent as per the README + docker-compose on the local machine. (Without docker-compose is also an option, but that seems to require a very large heap space, did not get there).

Other than that, the test is almost identical to the transfer-01 test. I did not run assertTransferProcessStatusConsumerSide, since there is actually also an error like No checker found for process 2bfb0f52-15f4-4028-8337-ccd1c4144de1. The process will not advance to the COMPLETED state.. Not sure if this is related to eclipse-edc/Connector#3334 or due to some missing configuration

[ndr-brt]

test is broke because it expects to find the agent jar, but it doesn't

[matthiasdg]

Yes, I put that in the comment. If you want to have a test like this and don't want to check in this file (README already mentioned the manual download), maybe can be downloaded from the github action. Also not sure whether this will run on a github actions runner.
The waitingFor can probably also use some improvement

[ndr-brt]

@matthiasdg We could have it downloaded by gradle as it has been implemented by tractusx

[github-actions]

This pull request is stale because it has been open for 7 days with no activity.

[Jens011203]

Hello, the issue is still not solved. If you have time, it would be nice if you could commit the code to the main branch.😀

[github-actions]

This pull request is stale because it has been open for 7 days with no activity.

[github-actions]

This pull request was closed because it has been inactive for 7 days since being marked as stale.

[ndr-brt]

@matthiasdg we were near to the solution, could you take care of fixing the CI? I will merge then

[github-actions]

This pull request is stale because it has been open for 7 days with no activity.

[github-actions]

This pull request was closed because it has been inactive for 7 days since being marked as stale.