Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): change contributing.md link to correct one #145

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

egekorkan
Copy link
Contributor

What this PR changes/adds

fixes a link

Why it does that

because it was wrong

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact the CONTRIBUTING.md file can be removed and a reference to the central CONTRIBUTING file could be added to the README.md, as it was done in the Connector README. Could you do that in this PR?

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Nov 13, 2023
@egekorkan
Copy link
Contributor Author

@ndr-brt I have done that now :)

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ndr-brt ndr-brt merged commit e837a2f into eclipse-edc:main Nov 13, 2023
3 checks passed
majadlymhmd pushed a commit to FraunhoferISST/edc-samples that referenced this pull request Nov 20, 2023
* fix(docs): change contributing.md link to correct one

* fix(docs): point to common repo readme rather than same repo

* fix(docs): delete contributing.md since we point to core repo now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants