Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add streaming kafka-to-http sample #108

Merged
merged 10 commits into from
Sep 25, 2023

Conversation

yurimssilva
Copy link
Contributor

What this PR changes/adds

Create a simple streaming sample.

Why it does that

documenting streaming capabilities

Linked Issue(s)

Closes #107

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

@juliapampus juliapampus added the enhancement New feature or request label Sep 5, 2023
@ndr-brt ndr-brt self-requested a review September 5, 2023 07:04
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an automated test to ensure that the sample is working, it's really useful for ensuring that will not suffer from regressions when we will update dependencies

@yurimssilva yurimssilva force-pushed the feat/101-streaming-kafka-to-http branch 3 times, most recently from 013c0a0 to 74d10a3 Compare September 6, 2023 20:17
@yurimssilva yurimssilva force-pushed the feat/101-streaming-kafka-to-http branch from 74d10a3 to 62a77ec Compare September 6, 2023 20:33
@yurimssilva yurimssilva force-pushed the feat/101-streaming-kafka-to-http branch from 62a77ec to 7961e78 Compare September 6, 2023 20:37
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, and the test needs to be fixed, for the rest we're good to go!

@ndr-brt
Copy link
Member

ndr-brt commented Sep 15, 2023

@yurimssilva please fix the e2e tests, then I will merge it

@ndr-brt ndr-brt merged commit d083cea into eclipse-edc:main Sep 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Streaming KAFKA-TO-HTTP streaming sample
4 participants