-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add streaming kafka-to-http sample #108
feat: add streaming kafka-to-http sample #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide an automated test to ensure that the sample is working, it's really useful for ensuring that will not suffer from regressions when we will update dependencies
...ing/streaming-02-kafka-to-http/insomnia-collection/kafka-to-http-insomnia-v4-collection.json
Outdated
Show resolved
Hide resolved
transfer/streaming/streaming-02-kafka-to-http/kafka-server/docker-compose.yaml
Outdated
Show resolved
Hide resolved
transfer/streaming/streaming-02-kafka-to-http/streaming-02-runtime/build.gradle.kts
Outdated
Show resolved
Hide resolved
013c0a0
to
74d10a3
Compare
74d10a3
to
62a77ec
Compare
Co-authored-by: ndr_brt <[email protected]>
62a77ec
to
7961e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, and the test needs to be fixed, for the rest we're good to go!
...sts/src/test/java/org/eclipse/edc/samples/transfer/streaming/Streaming02KafkaToHttpTest.java
Outdated
Show resolved
Hide resolved
@yurimssilva please fix the e2e tests, then I will merge it |
What this PR changes/adds
Create a simple streaming sample.
Why it does that
documenting streaming capabilities
Linked Issue(s)
Closes #107