Fix update API - allow using floating-point types (#3929)

* fix update API Signed-off-by: Iliyan Velichkov <[email protected]> * format the code Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]>
eclipse-dirigible · May 16, 2024 · 78cb3f2 · 78cb3f2
1 parent 2d2c185
commit 78cb3f2
Showing 1 changed file with 46 additions and 19 deletions.
diff --git a/.../api-database/src/main/java/org/eclipse/dirigible/components/api/db/ParametersSetter.java b/.../api-database/src/main/java/org/eclipse/dirigible/components/api/db/ParametersSetter.java
@@ -9,26 +9,23 @@
  */
 package org.eclipse.dirigible.components.api.db;
 
-import java.io.ByteArrayInputStream;
-import java.sql.Date;
-import java.sql.PreparedStatement;
-import java.sql.SQLException;
-import java.sql.Time;
-import java.sql.Timestamp;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
-import java.util.Calendar;
-import java.util.Locale;
-import java.util.Set;
+import com.google.gson.JsonArray;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonObject;
 import org.eclipse.dirigible.commons.api.helpers.BytesHelper;
 import org.eclipse.dirigible.commons.api.helpers.GsonHelper;
 import org.eclipse.dirigible.components.database.NamedParameterStatement;
 import org.eclipse.dirigible.database.sql.DataTypeUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import com.google.gson.JsonArray;
-import com.google.gson.JsonElement;
-import com.google.gson.JsonObject;
+
+import java.io.ByteArrayInputStream;
+import java.sql.*;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.Calendar;
+import java.util.Locale;
+import java.util.Set;
 
 /**
  * The Class ParametersSetter.
@@ -138,11 +135,25 @@ private static void setJsonPrimitiveParam(PreparedStatement preparedStatement, i
     private static void setNumber(PreparedStatement preparedStatement, int paramIndex, JsonElement parameterElement) throws SQLException {
         boolean isNumberParameterSet = false;
         int numberIndex = paramIndex;
-        try {
-            preparedStatement.setInt(numberIndex, parameterElement.getAsInt());
-            isNumberParameterSet = true;
-        } catch (SQLException | ClassCastException e) {
-            // Do nothing
+
+        double doubleValue = parameterElement.getAsDouble();
+        boolean floatingPointValue = doubleValue % 1 != 0;
+        if (floatingPointValue) {
+            try {
+                preparedStatement.setDouble(numberIndex, doubleValue);
+                return;
+            } catch (SQLException | ClassCastException e) {
+                // Do nothing
+            }
+        }
+
+        if (!isNumberParameterSet) {
+            try {
+                preparedStatement.setInt(numberIndex, parameterElement.getAsInt());
+                isNumberParameterSet = true;
+            } catch (SQLException | ClassCastException e) {
+                // Do nothing
+            }
         }
 
         if (!isNumberParameterSet) {
@@ -153,6 +164,7 @@ private static void setNumber(PreparedStatement preparedStatement, int paramInde
                 // Do nothing
             }
         }
+
         if (!isNumberParameterSet) {
             try {
                 preparedStatement.setLong(numberIndex, parameterElement.getAsLong());
@@ -161,6 +173,7 @@ private static void setNumber(PreparedStatement preparedStatement, int paramInde
                 // Do nothing
             }
         }
+
         if (!isNumberParameterSet) {
             try {
                 preparedStatement.setBigDecimal(numberIndex, parameterElement.getAsBigDecimal());
@@ -169,6 +182,7 @@ private static void setNumber(PreparedStatement preparedStatement, int paramInde
                 // Do nothing
             }
         }
+
         if (!isNumberParameterSet) {
             preparedStatement.setObject(numberIndex, parameterElement.getAsNumber()
                                                                      .toString());
@@ -266,6 +280,7 @@ void setParam(JsonElement sourceParam, String paramName, NamedParameterStatement
                 throws SQLException;
     }
 
+
     /**
      * The Class BaseParamSetter.
      */
@@ -282,6 +297,7 @@ protected void throwWrongValue(JsonElement sourceParam, String dataType) {
         }
     }
 
+
     /**
      * The Class TextParamSetter.
      */
@@ -342,6 +358,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class DateParamSetter.
      */
@@ -437,6 +454,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class TimestampParamSetter.
      */
@@ -557,6 +575,7 @@ private long getTime(String timestampString) {
         }
     }
 
+
     /**
      * The Class TimeParamSetter.
      */
@@ -654,6 +673,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class IntegerParamSetter.
      */
@@ -729,6 +749,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class TinyIntParamSetter.
      */
@@ -804,6 +825,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class SmallIntParamSetter.
      */
@@ -879,6 +901,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class BigIntParamSetter.
      */
@@ -956,6 +979,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class RealParamSetter.
      */
@@ -1033,6 +1057,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class DoubleParamSetter.
      */
@@ -1110,6 +1135,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class BooleanParamSetter.
      */
@@ -1185,6 +1211,7 @@ public void setParam(JsonElement sourceParam, String paramName, NamedParameterSt
         }
     }
 
+
     /**
      * The Class BlobParamSetter.
      */