Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/partition-matching-handling #37

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Feature/partition-matching-handling #37

merged 5 commits into from
Jan 7, 2025

Conversation

trittsv
Copy link
Contributor

@trittsv trittsv commented Dec 26, 2024

This PR closes #30

  • No qos-mismatch-warning are shown anymore for partitions
  • Partitions are shown inside the topic view
  • By clicking on a partition all the matching partitions are shown

Thanks a lot to @hansvanthag for the input.

This is how it looks:

  • Matching partitions have a green background
  • The selected partition additionally has a orange border
Screenshot 2024-12-26 at 08 32 22

@eboasson could you have a look?

eboasson
eboasson approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you ☺️

@eboasson eboasson merged commit 3c2a968 into eclipse-cyclonedds:master Jan 7, 2025
5 checks passed
@trittsv trittsv deleted the feature/improve-partition-handling branch January 7, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboasson eboasson eboasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partition matching
2 participants
@trittsv @eboasson