Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Advanced Authorization #39

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat: Advanced Authorization #39

merged 1 commit into from
Jan 29, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Jan 24, 2024 •
edited
Loading

@ibuziuk ibuziuk marked this pull request as ready for review January 25, 2024 11:47
@ibuziuk ibuziuk requested a review from l0rd as a code owner January 25, 2024 11:47
@ibuziuk ibuziuk requested a review from tolusha January 25, 2024 12:21
@ibuziuk ibuziuk closed this Jan 25, 2024
@ibuziuk ibuziuk reopened this Jan 25, 2024
tolusha
tolusha reviewed Jan 26, 2024
View reviewed changes
_posts/2024-01-29-advanced-authorization.adoc Outdated
description: >-
The article describes how to configure advanced authorization in Eclipse Che
categories: []
keywords: ['postgresql']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste?

l0rd
l0rd approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very good. I like this blog post a lot. My only recommendation would be to use a different title. For example "Granular Configuration of Eclipse Che Authorized users" is a more precise title and it gives an idea of what's the blog about.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 26, 2024

Thank you for the review, going to update the title and publish it on Monday 29.01 cc: @tolusha @dkwon17

@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 29, 2024 •
edited
Loading

new title is Unlocking Enhanced Authorization: A Guide to Configuring Granular Access for Eclipse Che Users
Previous one was too wordy, changing it to Configuring Granular Access for Eclipse Che Authorized Users

@ibuziuk
feat: Advanced Authorization
8f18ac4 
Signed-off-by: Ilya Buziuk <[email protected]>
@ibuziuk ibuziuk merged commit d6742b5 into main Jan 29, 2024
6 checks passed
@ibuziuk ibuziuk deleted the che-22757 branch January 29, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwon17 dkwon17 dkwon17 left review comments

@tolusha tolusha tolusha left review comments

@l0rd l0rd l0rd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibuziuk @l0rd @tolusha @dkwon17