Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage gerrithub.io #324

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Manage gerrithub.io #324

merged 2 commits into from
Nov 30, 2023

Conversation

heurtematte
Copy link
Contributor

It allows to specify a new entry in config.jsonnet to mount secret in pod by specifying site for gerrit.

Example with egit:

Add secret first:

./secret/create_gerrit_ssh_keys_secret.sh technology.egit gerrithub.io

And apply new jiro configuration:

{
  project+: {
    fullName: "technology.egit",
    displayName: "Eclipse EGit",
    resourcePacks: 2,
  },
  jenkins+: {
    theme: "quicksilver-light",
    plugins+: [
      "dashboard-view",
      "gerrit-trigger",
    ],
  },
  gerrit+: [
    { site: "gerrithub.io" }
  ],
}

Related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3137

@heurtematte heurtematte requested a review from fredg02 November 8, 2023 11:09
@heurtematte
Copy link
Contributor Author

@fredg02 can you take a look at my comments?

@fredg02 fredg02 merged commit d5dc2b5 into master Nov 30, 2023
2 checks passed
@fredg02 fredg02 deleted the feat/gerrithub branch November 30, 2023 19:22
@fredg02
Copy link
Contributor

fredg02 commented Nov 30, 2023

Had to fix an error when trying to deploy a project that does not have

gerrit+: {
  //something
}

set in config.jsonnet.

See fde7565.

@heurtematte
Copy link
Contributor Author

@fredg02 What is your jsonnet package and version?

@fredg02
Copy link
Contributor

fredg02 commented Dec 1, 2023

@fredg02 What is your jsonnet package and version?

I was on 0.17.0 until today. Upgraded to 0.18.0 now.

@heurtematte
Copy link
Contributor Author

heurtematte commented Dec 1, 2023

I use the Go implementation. 0.20.0 version. They may have slight differences between those implementations or versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants