Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Composite Creation Implementation #988

Open
wants to merge 16 commits into
base: workspace-composites
Choose a base branch
from

Conversation

kuzniarz
Copy link

Added most of the features to create a non functional workspace
composite, including:

  • Definition of composite via wizard and working set GUI
  • Adding projects to the composite via wizard and properties
  • Changing composite properties via properties menu

Import of external projects has yet to be implemented

Signed-off-by: kuzniarz [email protected]

@donat donat self-requested a review May 15, 2020 12:47
kuzniarz and others added 2 commits May 15, 2020 14:59
…clipse-buildship#867)

* Implemented no-op UIs for workspace-composite wizard + preferences
* Changed workspace composite wizard element name
* Changed composite wizard element description
* Fixed java doc and useless indent
* Javadoc/author fix+ line nitpick
* Remove UiBuilder
* Fixed indend
* Fixed javadoc and indent
* Remove UiBuilder/JavaDoc fix
* Fixed checkbox tree layout
* Refactor HelpContextIdProvider and WizardHelper
* Knitpick and format fix

Signed-off-by: kuzniarz <[email protected]>
@donat donat force-pushed the workspace-composites branch from 8d4b399 to 8e2d278 Compare May 15, 2020 13:53
kuzniarz and others added 4 commits May 15, 2020 17:44
Added most of the features to create a non functional workspace
composite, including:
- Definition of composite via wizard and working set GUI
- Adding projects to the composite via wizard and properties
- Changing composite properties via properties menu

Import of external projects has yet to be implemented

Signed-off-by: kuzniarz <[email protected]>
Composite properties file creation was failing if properties directory
was not existent

Signed-off-by: kuzniarz <[email protected]>
@donat donat closed this May 18, 2020
@donat donat force-pushed the workspace-composites branch from b8e7754 to 8e2d278 Compare May 18, 2020 14:46
@donat donat reopened this May 18, 2020
Commited by accident

Signed-off-by: kuzniarz <[email protected]>
@kuzniarz
Copy link
Author

I've fixed all the mentioned issues. The root project definition does not work properly right now but I will include a fix in the next commit!

@donat
Copy link
Contributor

donat commented Jun 16, 2020

I'll take a look soon. Sorry for the delay, once again I was dragged into another project.

- Fixed all requested PR changes
- Started implementing new CompositeSelectionDialog


Signed-off-by: kuzniarz <[email protected]>
@kuzniarz
Copy link
Author

No worries! I' ve just committed all changes along with the WIP GUI for the composite configuration.

- composite selection is not implemented yet

Signed-off-by: kuzniarz <[email protected]>
@kuzniarz kuzniarz force-pushed the workspace-composites branch from 3d0ea41 to 85ba1cd Compare June 23, 2020 15:39
- Changed GUI functionality and fixed several configuration bugs
- Added GUI-Strings to messages class

Signed-off-by: kuzniarz <[email protected]>
@kuniss
Copy link

kuniss commented Apr 6, 2021

@donat Any chance that this gets pushed forward by the Gradle team?
We are currently stack now with Eclipse 2020-06 and Gradle 4.10.3.

Eclipse 2020-06 is the last one which allows Java 8 which is required by the Gradle STS Eclipse plugin (Java version determination problem). Gradle 4.10.3 is the last one which supports the Tool API version 3 required by the Gradle STS plugin.

Now we are desperately waiting for this PR to be pushed forward into a solution to get at Buildship the same functionality as Gradle STS has for composite builds.

We have done as far as we can to support this. Now some more Gradle internal know how is needed what we are lacking, unfortunately. Or, is there more we can do?

@donat
Copy link
Contributor

donat commented Apr 7, 2021

Ok, this is probably on me. I didn't receive a notification on the latest commits/comments. I cannot promise anything in terms of eta, but I'll take a look when I have some free time.

Next time don't hesitate to ping me sooner ;)

@kuniss
Copy link

kuniss commented May 20, 2021

@donat Is there still some change request open? GitHub tells so. But I guess, it is outdated.

BTW, any progress achievable in the next time for this PR from your side?

@kuniss
Copy link

kuniss commented Jul 6, 2021

@donat just a kindly remainder. 😃
Any progress to be expected here in the near future?

@donat
Copy link
Contributor

donat commented Jul 7, 2021

As much as it hurts to say this, but I don't have time to look into this in the near future. I might be able to look into this in my free time but I'm not working full time on this project at the moment and no work has been scheduled for me on the Eclipse front. I'm still doing maintenance and review PRs though, so community contributions will get merged.

@kuniss
Copy link

kuniss commented Jul 7, 2021

Hi @donat, don't worry. That's (developer's) live. 😄

Of course, we would appreciate any work from your side on this. But please, do not feel obligated.
If you have any idea how we could support or push this forward from our side, reach out to us.

@kuniss
Copy link

kuniss commented Nov 10, 2021

@donat Any chance to get guidance from the Gradle team here (not necessarily from you). I guess, "only" the integration/ connection with/to the Gradle Tools Provider API is left. All the GUI work is already done.

We could support further, but we would need some guidance... Maybe, you could discuss this in the Gradle team?

@donat
Copy link
Contributor

donat commented Nov 10, 2021

Hi! I'll get back to you on this soon. I'm in the process of planning some work in the IDE integration.

@kuniss
Copy link

kuniss commented Dec 14, 2021

Hey @donat, any news on that?
A Merry Christmas time! 😄

@kuniss
Copy link

kuniss commented Oct 12, 2022

Hey @donat, any chance to push this forward?
Can we in any way support further?

@kuniss
Copy link

kuniss commented Jul 5, 2023

Hey @donat, any chance to get this into the roadmap? 😃

@kuniss
Copy link

kuniss commented Oct 20, 2023

Hi @donat, this PR says, there are some change requests open. But I guess, @kuzniarz did all requested changes as he stated here.

Beside this, did you had any chance to put this PR on the roadmap?

Our offer is still valid...

kuzniarz and others added 2 commits October 25, 2023 11:14
…clipse-buildship#867)

* Implemented no-op UIs for workspace-composite wizard + preferences
* Changed workspace composite wizard element name
* Changed composite wizard element description
* Fixed java doc and useless indent
* Javadoc/author fix+ line nitpick
* Remove UiBuilder
* Fixed indend
* Fixed javadoc and indent
* Remove UiBuilder/JavaDoc fix
* Fixed checkbox tree layout
* Refactor HelpContextIdProvider and WizardHelper
* Knitpick and format fix

Signed-off-by: kuzniarz <[email protected]>
@donat donat force-pushed the workspace-composites branch from 8e2d278 to 1ac7f34 Compare October 25, 2023 09:15
@donat
Copy link
Contributor

donat commented Oct 25, 2023

Hi! I know I keep promising to look into this but given the size of the PR I seem to never find the time to deeply look into this. This changes now and here's what I think should happen. Let's get the PRs up-to-date with the latest main branch. I've updated this PR's base branch already. Please go ahead and rebase this PR as well. Also, the other thing I'd like to request is a feature description: please add description with screenshots on how this feature would work here. It will serve me as a "test plan" to evaluate the latest state. After manual testing, I'll come up with a list of what's missing before we can merge and release the feature (likely it will be stability, test coverage, documentation).

You can reach out to me via the Gradle Community Slack channel if you have any operational questions (you'll find an invite on the top of this page).

@kuniss
Copy link

kuniss commented Nov 2, 2023

Good to hear, @donat! Let's push this forward.

@kuzniarz will start working on the description in the next week.

P.S. We are not allowed to access Slack from our corporate network. So, the discussion, if any, must take place here...

@kuzniarz
Copy link
Author

kuzniarz commented Nov 3, 2023

I think I resolved all conflicts successfully! I will add the feature description in your provided documentation and let you know then @donat Thanks for your work!

kuzniarz and others added 2 commits November 3, 2023 16:50
- Added missing change of Guava
This reverts commit 09fcacd.
Updated MANIFEST.MF to be up to date with upstream

Signed-off-by: Sebastian <[email protected]>
@kuzniarz
Copy link
Author

kuzniarz commented Nov 3, 2023

Okay, the build seems to fail, I need to look into that. Also something got messed up with signing off the commit. I suppose this is due to my system change and additionally a new email configured in github. I'll fix that on monday. Have a nice weekend guys!

@kuzniarz
Copy link
Author

Hi @donat ! Sorry for the late update, rebasing the project turned out to be a little more of a struggle than expected. I also realized, that you rebased the wrong branch! You have created a new, more recent branch in the past than the workspace-composite one. The branch is called 'kuzniarz-workspace-composites-rebased'!

Currently I reverted my local changes to the point before trying to merge/rebase it (before commit faafa91) and trying to rebase it to be as updated as the 'workspace-composite' branch, in terms of your changes.

My other option is to checkout the 'workspace-composite' branch and cherry-pick the changes from 'kuzniarz-workspace-composites-rebase' onto it. I'll let you know about the status till the end of the week.

@kuzniarz
Copy link
Author

kuzniarz commented Feb 8, 2024

Hi @donat, sorry for the long break as I did not have time to tackle this mess of a PR. Nonetheless, I finally managed. I have created a new pull request (#1297), as this one was not the correct branch with the most recent version. Alternatively I can cherrypick the changes from the other branch onto this one if thats your preferred way to handle the PR. If there is anything else to do with the commits, please let me know!

@donat
Copy link
Contributor

donat commented Apr 8, 2024 via email

@kuniss
Copy link

kuniss commented Apr 9, 2024

@donat, the initial PR is now nearly 4 years old. No wonder, it is nonreviewable... 😄 ... We tried to keep up with the changes on the main branch.

However, due to that @kuzniarz has created a new PR #1297, see his last comment.
Does your comment belongs to that PR too?

If not, we can close this PR and continue at #1297.

If yes, what is your recommendation how to proceed from there?

@donat donat force-pushed the workspace-composites branch 2 times, most recently from fa500a5 to 67babac Compare April 19, 2024 14:30
@donat
Copy link
Contributor

donat commented Apr 22, 2024

Hi! I did a bit of cleanup on Friday. The latest state is tracked on the kuzniarz-workspace-composites-rebased branch. It is based on the latest master and it has exactly two commits: the one introducing the no-op UI elements and another one with the prototype functionality. I haven't done any testing after I did the rebase so there's no guarantee that it works as intended. Can you please take a look?

@kuzniarz
Copy link
Author

Hi @donat! Thanks a lot for rebasing kuzniarz-workspace-composites-rebased! This should be the branch with the most recent changes that I have developed in the past! I will check if everything works as intended today and add some info to the Overview.md!

@donat
Copy link
Contributor

donat commented Apr 22, 2024

Sounds good, thanks for following up.

@kuzniarz
Copy link
Author

@donat So I was able to check the rebased version and most of it looks fine! I have to change a few minor details but I'm going to create a pull request with the needed changes as soon as thats done! Thanks again for the rebase!

@kuzniarz
Copy link
Author

kuzniarz commented Jul 1, 2024

I've created a new PR with the required changes, #1307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants