-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental LSP in order to support Declarative Gradle's DCL files #1320
Conversation
README.md
Outdated
> [!IMPORTANT] | ||
> This is a forked repository that is adding [Declarative Gradle](https://declarative.gradle.org/) support to normal Buildship. | ||
> The following instructions will help you to get started. | ||
|
||
### Setup: update site-based installation | ||
|
||
> [!TIP] | ||
> This installation method is preferred if you don't want to develop the plugins. | ||
|
||
1. Open the "Help > Install New Software..." dialog | ||
2. In the "Work with:" field, paste the following link: https://hegyibalint.github.io/buildship/ | ||
3. Under "Buildship Extras - Incubating" there should be a new option: _"Buildship - Gradle Declarative editor support"_ | ||
4. Select the option and proceed with the installation | ||
5. After installation, go to the "Settings > Gradle > Experimental features" menu, and select the `lsp-all.jar` file (the file is the result of `shadowJar` assembled by [declarative-lsp](https://github.com/gradle/declarative-lsp), see that repository for further instructions) | ||
|
||
The installation can be kept up-to-date, just go to "Help > Check for Updates". | ||
If there is a new snapshot version of the plugin, the dialog will offer the new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ This needs to go, I will need to move this.
@donat WDYT, where could we put this so users trying out the feature could discover these instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add a line here and reference a dedicated document in the docs
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to docs/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a single-line TIP admonition about where to find the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/user/DeclarativeGradle.md
Outdated
Our main flagship project showcasing the capabilities is the [unified-prototype](https://github.com/gradle/declarative-gradle/tree/main/unified-prototype). | ||
This project is importable by Buildship (even without the declarative support). The project needs the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unified-prototype folder in there is not the flagship project showcasing declarative. It contains some supporting plugins and builds that are ~ integration tests for it.
Please point to https://declarative.gradle.org/docs/getting-started/samples/ instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
I've rebased and reauthored my commit, but still something doesn't add up |
1cbc741
to
5a17976
Compare
@hegyibalint Thank you for the contribution! |
Context
Declarative Gradle introduces a new file format
dcl
.As this file is based on our DCL language, we need extra tooling to support it.
Currently, we are developing an LSP to handle the file, and this PR introduces a new plugin using this server.