Render Gradle problem reports as Eclipse error markers #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donat
changed the title
donat
force-pushed
the
donat/problems-attempt
branch
from
eddc018 to
1425085
Compare
donat
commented
Jun 10, 2024
| private void reportProblem(SingleProblemEvent event) { | ||
| List<Location> locations = event.getLocations(); | ||
|
|
||
| // 1/4 offset in file location |
There was a problem hiding this comment.
We could make this bit a bit cleaner; let's discuss details.
|
@reinsch82 I'm interested in your initial feedback. |
reinsch82
reviewed
Jun 10, 2024
...ildship.core/src/main/java/org/eclipse/buildship/core/internal/marker/GradleErrorMarker.java
Show resolved
Hide resolved
...ava/org/eclipse/buildship/core/internal/util/progress/ProblemsReportingProgressListener.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/buildship/core/internal/util/progress/ProblemsReportingProgressListener.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/buildship/core/internal/util/progress/ProblemsReportingProgressListener.java
Outdated
Show resolved
Hide resolved
donat
force-pushed
the
donat/problems-attempt
branch
2 times, most recently
from
3bc0216 to
51d75cd
Compare
stanio
reviewed
Jul 16, 2024
donat
force-pushed
the
donat/problems-attempt
branch
from
ab76b10 to
8cd62b9
Compare
reinsch82
approved these changes
Jul 19, 2024
| @@ -33,14 +33,14 @@ class WorkspaceConfigurationTest extends WorkspaceSpecification { | |||
| } | |||
|
|
|||
| @Rollup | |||
| def "Can save workpsace configuration"(GradleDistribution distribution, String gradleUserHome, String javaHome, boolean offlineMode, boolean buildScansEnabled, boolean autoSync, List args, List jvmArgs, boolean showConsole, boolean showExecutions, moduleSupportEnabled) { | |||
| def "Can save workspace configuration"(GradleDistribution distribution, String gradleUserHome, String javaHome, boolean offlineMode, boolean buildScansEnabled, boolean autoSync, List args, List jvmArgs, boolean showConsole, boolean showExecutions, moduleSupportEnabled) { | |||
There was a problem hiding this comment.
🤔 I guess that should be there
Suggested change
| def "Can save workspace configuration"(GradleDistribution distribution, String gradleUserHome, String javaHome, boolean offlineMode, boolean buildScansEnabled, boolean autoSync, List args, List jvmArgs, boolean showConsole, boolean showExecutions, moduleSupportEnabled) { | |
| def "Can save workspace configuration"(GradleDistribution distribution, String gradleUserHome, String javaHome, boolean offlineMode, boolean buildScansEnabled, boolean autoSync, List args, List jvmArgs, boolean showConsole, boolean showExecutions, boolean moduleSupportEnabled) { |
| } | ||
|
|
||
| public static int countLines(String str) { | ||
| return Lists.newArrayList(Splitter.on(System.lineSeparator()).split(str)).size(); |
There was a problem hiding this comment.
🤔 Maybe?
Suggested change
| return Lists.newArrayList(Splitter.on(System.lineSeparator()).split(str)).size(); | |
| return Splitter.on(System.lineSeparator()).splitToList(str).size(); |
donat
force-pushed
the
donat/problems-attempt
branch
from
06bb0ed to
0866650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gradle Tooling API now exposes problem reports via Tooling API events. This change implements a listener consuming problem events an converting them to Eclipse error markers.
The feature is not enabled by default. Users need to explicitly opt-in for the time being.
Reported problems show up in the Eclipse Problems view under the
Gradle Problemtype. The reports are cleared and recreated for every build invocation (sync and task execution).The error marker has a custom properties page with the report details. Documentation links are navigable and there's a button for copying the stacktrace, just like on the generic Eclipse marker properties page.
Tasks