Fix editor bindings for gradle.properties and Kotlin DSL files #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for the editor content type bindings configured in the plugin.xml to work correctly, the missing dependencies for the Generic Text Editor have to be added. For Gradle Properties the content type configuration should use the full file name "gradle.properties" without a separate entry for the file extension, so that these files are opened with the Generic Text Editor and other property files are still handled by the Properties File Editor.
|
I've tested your changes and it does fix the editor association issue. It's not documented in the PR's title, but you also fixed the editor association for the .gradle.kts files 🎉 . |
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the editor content type bindings configured in the
plugin.xmlto work correctly, the missing dependencies for the Generic Text Editor have to be added.For Gradle Properties the content type configuration should use the full file name
gradle.propertieswithout a separate entry for the file extension, so that these files are opened with the Generic Text Editor and other property files are still handled by the Properties File Editor.