Save versions cache file in plugin's state location by default #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I really need to give my address for this tiny change? Here's the action run btw: https://github.com/altrisi/buildship/actions/runs/3553609398/jobs/5969212032 |
|
Any input on this? It's been over 2 months without response. |
|
Hi! Sorry for the late response. I'm fine with the changes. The only thing blocking this PR is that you need to sign the Eclipse Contributor Agreement: eclipse.org/projects/handbook/#resources-github |
donat
force-pushed
the
master
branch
5 times, most recently
from
7e55112 to
7040f04
Compare
|
I got no response so I assume the PR is abandoned. I still think there's value here, so I implemented my variant. Superseded by #1312 |
|
Completely missed that comment sorry, but thanks for considering and implementing the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1178.
This PR changes the folder where the versions cache is stored to be inside buildship's state location. It keeps the xdgcache thing though and will use it if it's set.
Context
In my case, the
.cachefolder where it was being saved previously was only used for this one file, and I doubt I'm the only one. Not only that, I think it makes sense for buildship's files to be in buildship's folder, according to this Eclipse wiki page it's the folder that should be used for "cached information".Only testing I ran was from the set up Github Actions. Weirdly the default build failed because Gradle was unable to find dependencies for the
buildSrcproject. I changed the repos (in another branch) just for the purposes of running the build, and it then passed.