Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage module integration with INI file handling. #232

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

franz-hoepfinger-4diac
Copy link

@franz-hoepfinger-4diac franz-hoepfinger-4diac commented Sep 17, 2024

Add storage module integration with INI file handling. Include options to enable INI with CMake and implement functions for loading and storing data from settings.ini by section and key.

  • Added CMakeLists.txt for storage module integration.
  • Added CMakeLists.txt for INI handling within the storage module.
  • Implemented functions in INI_fbt.cpp to load and store data from settings.ini by section and key.

Backend-wise this is based on:
https://github.com/DiplomInformatikerFranzHoepfinger/SimpleIni_on_esp32

should run on Windows, Linux and others.
Tested on ESP32 FAT Filesystem.

there are Alternative Backends to the ini Backend available as well.
(on Request)

@franz-hoepfinger-4diac
Copy link
Author

Copy link
Contributor

@azoitl azoitl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clean the commit message and the comments. I don't see any OPC UA in your commit!

@diplfranzhoepfinger
Copy link

Can you please clean the commit message and the comments. I don't see any OPC UA in your commit!

i do ....

@franz-hoepfinger-4diac franz-hoepfinger-4diac changed the title Add storage module integration with INI file handling. Include options to enable OPC UA with CMake and implement functions for loading and storing data from settings.ini by section and key. Add storage module integration with INI file handling. Include options to enable it with CMake and implement functions for loading and storing data from settings.ini by section and key. Sep 19, 2024
…s to enable it with CMake and implement functions for loading and storing data from settings.ini by section and key.

Add storage module integration with INI file handling. Include options to enable itA with CMake and implement functions for loading and storing data from settings.ini by section and key.

- Added CMakeLists.txt for storage module integration.
- Added CMakeLists.txt for INI handling within the storage module.
- Implemented functions in INI_fbt.cpp to load and store data from settings.ini by section and key.
Update copyright year to 2024 and contributors in storage module files.

Updated the copyright year to 2024 and contributors in the storage module files.
Updated getValue() to c_str() for CIEC_STRING in executeSet and executeGet functions.
- Added clarification for enabling the storage module in CMake.
@franz-hoepfinger-4diac
Copy link
Author

cleaned it up ...

@azoitl
Copy link
Contributor

azoitl commented Sep 19, 2024

I don't think it makes sense to have this in the official 4diac FORTE repo. It introduces an undocumented hidden dependency to your code. This strongly violates the Eclipse development process. I think it makes more sense that you build up your own repo where you put that kind of stuff together and use it for your builds via an external module.

Copy link
Author

@franz-hoepfinger-4diac franz-hoepfinger-4diac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done.

@franz-hoepfinger-4diac
Copy link
Author

It introduces an undocumented hidden dependency to your code.

OK. sorry for that.
i need to learn how to make it right.
and it is not my Code, it is from other People, but its MIT.

This strongly violates the Eclipse development process.

yes, sorry, i need step by step learn it.

@azoitl
Copy link
Contributor

azoitl commented Sep 20, 2024

The Eclipse development process has a very clear position on third party content. It needs to be clearly marked and also reproted. You can see all third party dependency Eclipse 4diac has in our project pages. For that we need to report them and get them veted and approved. We normally don't accept just a github repo as third party dependency. It has to be certain releases, because between releases licenses may change.

@diplfranzhoepfinger
Copy link

yes, must learn this !

@franz-hoepfinger-4diac franz-hoepfinger-4diac changed the title Add storage module integration with INI file handling. Include options to enable it with CMake and implement functions for loading and storing data from settings.ini by section and key. Add storage module integration with INI file handling. Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants