-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage module integration with INI file handling. #232
base: develop
Are you sure you want to change the base?
Add storage module integration with INI file handling. #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please clean the commit message and the comments. I don't see any OPC UA in your commit!
i do .... |
…s to enable it with CMake and implement functions for loading and storing data from settings.ini by section and key. Add storage module integration with INI file handling. Include options to enable itA with CMake and implement functions for loading and storing data from settings.ini by section and key. - Added CMakeLists.txt for storage module integration. - Added CMakeLists.txt for INI handling within the storage module. - Implemented functions in INI_fbt.cpp to load and store data from settings.ini by section and key.
Update copyright year to 2024 and contributors in storage module files. Updated the copyright year to 2024 and contributors in the storage module files.
Updated getValue() to c_str() for CIEC_STRING in executeSet and executeGet functions.
f0f571a
to
fba231b
Compare
- Added clarification for enabling the storage module in CMake.
cleaned it up ... |
I don't think it makes sense to have this in the official 4diac FORTE repo. It introduces an undocumented hidden dependency to your code. This strongly violates the Eclipse development process. I think it makes more sense that you build up your own repo where you put that kind of stuff together and use it for your builds via an external module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes done.
OK. sorry for that.
yes, sorry, i need step by step learn it. |
The Eclipse development process has a very clear position on third party content. It needs to be clearly marked and also reproted. You can see all third party dependency Eclipse 4diac has in our project pages. For that we need to report them and get them veted and approved. We normally don't accept just a github repo as third party dependency. It has to be certain releases, because between releases licenses may change. |
yes, must learn this ! |
Add storage module integration with INI file handling. Include options to enable INI with CMake and implement functions for loading and storing data from settings.ini by section and key.
Backend-wise this is based on:
https://github.com/DiplomInformatikerFranzHoepfinger/SimpleIni_on_esp32
should run on Windows, Linux and others.
Tested on ESP32 FAT Filesystem.
there are Alternative Backends to the ini Backend available as well.
(on Request)