parser.go: Fix Bird 2.0 BGP protocol parsing #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Bird 2.0, BGP protocol lines have `---` as the table name, as the actual
table names are defined in the respective channels. This commit fixes the
regex to take this into account.
Parsing of the key-value section is also changed so that we don't mistake
the states of individual channels as the protocol state. In the future, we
should distinguish between different channels instead of parsing the key-value
section blindly.
Example:
```
xxx1_4 BGP --- up 2018-08-21 08:44:30 Established
Description: iBGP xxx1 v4
BGP state: Established
<snip>
Channel ipv4
State: UP
Table: master4
<snip>
```
- Expected `state`: `up`
- Parsed `state`: `UP` (from the ipv4 channel)
- Expected `state_changed`: `2018-08-21 08:44:30`
- Parsed `state_changed`: Not parsed
|
We might have to think about backward compatibility here (because including this PR as is would break BIRD 1.X)! This isn’t trivial, because we don’t want to make it too brittle and In other news, @mhannig (the current maintainer) is currently not available, so it will probably take a while before he’ll respond to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Bird 2.0, BGP protocol lines have
---as the table name, as the actual table names are defined in the respective channels. This commit fixes the regex to take this into account.Parsing of the key-value section is also changed so that we don't mistake the states of individual channels as the protocol state. In the future, we should distinguish between different channels instead of parsing the key-value section blindly.
Example:
state:upstate:UP(from the ipv4 channel)state_changed:2018-08-21 08:44:30state_changed: Not parsed