Dev

[brey]

No description provided.

[pmav99]

You should (almost) always add an else clase to an if/elif.

What if the user adds an invalid ihot value? Then hotout will not be defined and you will get a NameError which will confusing.

if instead we have:

else:
    raise ValueError("Acceptable values for `ihot` are 1 and 2, not: %s", ihot)

it will be immediately apparent what the issue is.

For the record, ideally, we should be validating the user input as soon as we get it, but to do that properly will require a major restructure so let's keep it simple for now.

[pmav99]

The formatting is ugly here. Either introduce new variables or maybe try some variation of this (I didn't test it):

            rnday_new = (self.sdate - self.rdate) + pd.to_timedelta(self.time_frame)
            rnday_new = rnday_new.total_seconds() / (3600 * 24.0)
            ...

[tomsail]

I would even suppress assigning self.obs (above here line 1755: self.obs = tg_database)
otherwise it gets written to <module>_model.json

[brey]

with the new implementation tg_database (and thus self.obs) is always a filename, either originally or after using searvey,

            tg_database = os.path.join(path, "stations.json")
            tg.to_file(tg_database)
        self.obs = tg_database