-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #161
Dev #161
Conversation
Use symlink for hgrid.ll save coastlines to file instead of the model json file - resolve ec-jrc#130 add control for external station dataframe dtype of lat/lon make sure the test works with symlinks
simplify more
# --------------------------------------------------------------------- | ||
logger.info("model finished successfully\n") | ||
# --------------------------------------------------------------------- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a biggie, but would it make sense to move this log message inside execute_schism_mpirun_script()
?
I guess the answer depends on whether the function is being used elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, if we put it in tools the logging reference will also be different.
pyposeidon.schism run:671 executing model
pyposeidon.tools :xxx model finished successfully
which might be misleading as well, but I am open to it if you think it's better.
With the first 6 days of May 2023 we get an exception:
|
If we define nc_out = 0 in the param.nml there is no map output. This way we avoid waiting for the geometry reindexing.
split in three separate functions
moving to list of variables as argument for one call functionality
No description provided.