[pull] master from ppy:master #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Improve performance of UR calculations
Fix hitobjects' samples getting in bad state when changing selection between objects
Fix classic skin spinner's middle pieces displaying in the wrong order
…-for-menu-tip Add localisation support for menu tip
…ow structure Co-authored-by: Dean Herbert <[email protected]>
I wasn't feeling well last night.
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
Not sure why I left this around during the refactor. This is 100% handled by the `DetachedBeatmapStore`. Removing this subscription reduces overheads by a huge amount for users with large beatmap databases. My hypothesis is that subscriptions are more expensive based on **the number of results matching**. This one matches almost every beatmap so removing it is a large win.
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint, the existing playlists results screen classes needed some restructuring.
This also optimises the manager classes to better support `Live` usage where the managed object is already in a good state (ie. doesn't require re-fetching).
This brings it down to be in line with the flowing elements that usually do their best to not get in the way. Decided against putting it in the `HUDOverlay` flow for simplicity. It will work fine until it doesn't.
As seen in https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588 or https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53. Exception messages hint pretty strongly at this being a threading issue and there does seem to be a rather frivolous lack of waiting for `CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will help.
Fix player settings overlay appearing while in skin editor
Attempt to fix flaky editor beatmap creation test
Add recommended difficulty numerical value near filter in beatmap listing
Fix player settings overlay cog overlapping skin elements
…ic failure Closes #31098. Low effort fix because it was already half broken. The test was testing in isolation but in actual editor usage it wasn't working as expected.
I actually thought things were bugged with the previous display method, since the hinting was very similar to the hover colour/state. I've adjusted this to hopefully give users a better idea of what this is intending to show them.
Allow using "quick retry" shortcut in more cases from results screen
Fix adjusting control point offset after undo/redo causing catastrophic failure
…nd other keywords
- Properly annotate things as nullable - Remove weird passthrough property (more on that later)
Localisable strings cannot be plainly interpolated or joined. That is a lossy operation that loses data.
This reverts commit c0b6e78. The change affects editor and other stuff and I'm not sure it's correct. It's not like client needs to match the appearance really. It already doesn't in many places.
Change the way "current" points are hinted on timing screen
Expose high precision mouse toggle when searching for "sensitivity" and other keywords
…ooltip Add missing mania tooltip overlay for 4k and 7k
Use time-based resume overlay when playing osu! on touchscreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )