Skip to content

Commit

Permalink
Add comments backreferences to copies of duplicated code for future use
Browse files Browse the repository at this point in the history
  • Loading branch information
bdach committed Dec 11, 2024
1 parent 1f43ad3 commit 5a0b732
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ private void updateHitObjectFromPath()
lastSliderPathVersion = HitObject.Path.Version.Value;
}

// duplicated in `SliderSelectionBlueprint.convertToStream()`
// consider extracting common helper when applying changes here
private void convertToStream()
{
if (editorBeatmap == null || beatDivisor == null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,8 @@ private void splitControlPoints(List<PathControlPoint> controlPointsToSplitAt)
HitObject.Position += first;
}

// duplicated in `JuiceStreamSelectionBlueprint.convertToStream()`
// consider extracting common helper when applying changes here
private void convertToStream()
{
if (editorBeatmap == null || beatDivisor == null)
Expand Down

0 comments on commit 5a0b732

Please sign in to comment.