[doctor][stack] check ceph.config #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,12 +13,12 @@ auth_cluster_required = cephx | |||
| auth_service_required = cephx | |||
| auth_client_required = cephx | |||
| filestore_xattr_use_omap = true | |||
| osd_pool_default_size = 2 | |||
| osd_pool_default_size = 3 | |||
There was a problem hiding this comment.
osd_pool_size 是 fuel 部署之前设置，我们一般都是 3 ，但是从 fuel 的 api 里 cluster 的 attributes 里或者任一台节点的 facts 里取比较好。
There was a problem hiding this comment.
例如：我们目前fuel cluster attributes和节点的facts及配置文件里面都是3，如果我们后面有需求把配置文件里的值修改成了4，我们在修改的时候会不会同时修改fuel cluster attributes及节点的facts？
There was a problem hiding this comment.
恩，这里会引发另外一个问题，ceph.conf 中 osd_pool_default_xxx 这些配置只对于新建 pool 而且不指定对应参数时有效，这些参数在后期都可以手动调整。而手动调整的情况如果只针对个别 pool ，则没有必要修改 ceph.conf 。
也就是 pool 的实际参数和 ceph.conf 不必保持一致，fuel 里面的 facts 其实也只对 fuel 布署时生效，后期也会对这些参数进行检查。
所以从检查配置文件的目的看，似乎从 fule 里取比较合理。
There was a problem hiding this comment.
先过滤掉这种fuel根据环境配置生成的变量的检测，后续单独增加获取这些特殊变量的正确值的方法（不再从template里获取）
blkart
force-pushed
the
check_ceph_config
branch
from
796bb9a to
17431a9
Compare
redmine #6354 Signed-off-by: blkart <[email protected]>
blkart
force-pushed
the
check_ceph_config
branch
from
17431a9 to
722f418
Compare
| if parser.PROFILE and not parser.SERVICE and not parser.CHECK_ALL: | ||
| if parser.CONTROLLER: | ||
| check('controller', 'profile') | ||
| if parser.COMPUTE: | ||
| check('compute', 'profile') | ||
| if parser.MONGO: | ||
| check('mongo', 'profile') | ||
| if parser.CEPHOSD: | ||
| check('ceph_osd', 'profile') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redmine #6354
Signed-off-by: blkart [email protected]