remove deprecated robust

easystats · Oct 19, 2024 · a7b97a5 · a7b97a5
1 parent 3fbe00f
commit a7b97a5
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 14 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: parameters
 Title: Processing of Model Parameters
-Version: 0.23.0.1
+Version: 0.23.0.2
 Authors@R:
     c(person(given = "Daniel",
              family = "Lüdecke",

diff --git a/R/3_p_value.R b/R/3_p_value.R
@@ -56,8 +56,8 @@ p_value.default <- function(model,
     method <- "wald"
   }
 
-  # robust standard errors with backward compatibility for `robust = TRUE`
-  if (!is.null(vcov) || isTRUE(dots[["robust"]])) {
+  # robust standard errors
+  if (!is.null(vcov)) {
     method <- "robust"
   }
 

diff --git a/R/4_standard_error.R b/R/4_standard_error.R
@@ -101,8 +101,8 @@ standard_error.default <- function(model,
     se <- .safe(sqrt(diag(do.call("vcov", fun_args))))
   }
 
-  # vcov: character (with backward compatibility for `robust = TRUE`)
-  if (is.character(vcov) || isTRUE(dots[["robust"]])) {
+  # vcov: character
+  if (is.character(vcov)) {
     .vcov <- insight::get_varcov(
       model,
       component = component,

diff --git a/R/extract_parameters.R b/R/extract_parameters.R
@@ -176,8 +176,7 @@
 
   # ==== test statistic - fix values for robust vcov
 
-  # deprecated argument `robust = TRUE`
-  if (!is.null(vcov) || isTRUE(dots[["robust"]])) {
+  if (!is.null(vcov)) {
     parameters$Statistic <- parameters$Estimate / parameters$SE
   } else if (!is.null(statistic)) {
     parameters <- merge(parameters, statistic, by = merge_by, sort = FALSE)

diff --git a/R/methods_nestedLogit.R b/R/methods_nestedLogit.R
@@ -103,8 +103,8 @@ standard_error.nestedLogit <- function(model,
     se <- .safe(sqrt(diag(do.call("vcov", fun_args))))
   }
 
-  # vcov: character (with backward compatibility for `robust = TRUE`)
-  if (is.character(vcov) || isTRUE(dots[["robust"]])) {
+  # vcov: character
+  if (is.character(vcov)) {
     .vcov <- insight::get_varcov(
       model,
       component = component,

diff --git a/R/p_value_kenward.R b/R/p_value_kenward.R
@@ -88,7 +88,7 @@ p_value_kenward.lmerMod <- function(model, dof = NULL) {
     if (is.null(se)) {
       se <- se_kenward(model)$SE
     }
-  } else if (!is.null(vcov) || isTRUE(list(...)[["robust"]])) {
+  } else if (!is.null(vcov)) {
     se <- standard_error(model,
       vcov = vcov,
       vcov_args = vcov_args,

diff --git a/R/standardize_info.R b/R/standardize_info.R
@@ -11,9 +11,9 @@
 #' @param ... Arguments passed to or from other methods.
 #'
 #' @return A data frame with information on each parameter (see
-#'   [parameters_type()]), and various standardization coefficients
-#'   for the post-hoc methods (see [standardize_parameters()]) for the predictor
-#'   and the response.
+#' [`parameters_type()`]), and various standardization coefficients
+#' for the post-hoc methods (see [`standardize_parameters()`]) for the predictor
+#' and the response.
 #'
 #' @family standardize
 #'

diff --git a/tests/testthat/test-model_parameters_robust.R b/tests/testthat/test-model_parameters_robust.R
@@ -75,7 +75,6 @@ mtcars$am <- as.factor(mtcars$am)
 model <- lm(mpg ~ wt * am + cyl + gear, data = mtcars)
 
 test_that("model_parameters, robust", {
-  expect_warning(expect_warning(expect_warning(model_parameters(model, robust = TRUE))))
   params <- model_parameters(model, vcov = "HC3")
   robust_se <- unname(sqrt(diag(sandwich::vcovHC(model))))
   expect_equal(params$SE, robust_se, tolerance = 1e-3)