more winsorizing options? #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please create an issue about this where we can discuss this, and then you link this PR to it? That way we will have a written record in issues about what motivated this change. :) Thanks! |
This was referenced Jan 5, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
|
we could add select helpers here, too. See |
|
My deadline for sending out my dissertation is 30/9, so before that I won't have time for anything other than a patch here or there... |
|
Cool. Marking this as a draft PR then. We can revisit this after #133. |
rempsyc
added a commit
to rempsyc/datawizard
that referenced
this pull request
Jun 25, 2022
… based on the MAD
IndrajeetPatil
pushed a commit
that referenced
this pull request
Jun 27, 2022
* addresses #177 & #49 & #47 for winsorizing based on the MAD * forgot to push updated documentation * new argument "method", updated NEWS, resolved failed test, #179 * update winsorize.numeric added raw method made the code easier to maintain by modularizing it made doc more explicit about the methods updated examples to visualize the effect update NEWS * minor modifications to docs * removed tidyr from Suggests, replaced `tidyr::pivot_longer` with `datawizard::data_to_long` in vignette * added new tests for new winsorization methods, insight::format_message(), data[] <- lapply... Co-authored-by: RemPsyc <[email protected]> Co-authored-by: Mattan S. Ben-Shachar <[email protected]>
|
@mattansb Do you think you will have time to finish this PR for a release in the next few weeks? |
|
Oh, I totally forgot about this... um, probably not... |
|
Ok, I close it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IndrajeetPatil Would you be open to one or more of the following while I'm at it:
threshold = c(bottom, top)?threshold% observations? Is that weird?