修复param引用

easy-swoole · Oct 11, 2023 · 16c7634 · 16c7634
1 parent 9e5a530
commit 16c7634
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/AnnotationController.php b/src/AnnotationController.php
@@ -147,6 +147,7 @@ private function paramValidate(Param $param,array $allDefineParams,Request $requ
             $rules = $param->validate;
             /** @var AbstractValidator $rule */
             foreach ($rules as $rule){
+                $rule = clone  $rule;
                 $rule->allCheckParams($allDefineParams);
                 $ret = $rule->execute($param,$request);
                 if(!$ret){

diff --git a/src/Attributes/Param.php b/src/Attributes/Param.php
@@ -256,12 +256,13 @@ public function hasSet():bool
 
    function __clone()
    {
-       $temp = [];
-       /** @var AbstractValidator $item */
-       foreach ($this->validate as $item){
-           $temp[$item->ruleName()] = clone $item;
-       }
-       $this->validate = $temp;
+       //规则在调用层做克隆，不然循环引用。
+//       $temp = [];
+//       /** @var AbstractValidator $item */
+//       foreach ($this->validate as $item){
+//           $temp[$item->ruleName()] = clone $item;
+//       }
+//       $this->validate = $temp;
 
        $temp = [];
        /** @var Param $item */