Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation errors #336

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix compilation errors #336

merged 2 commits into from
Jul 19, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Jul 19, 2024

@singhbalwinder singhbalwinder self-requested a review July 19, 2024 19:09
@singhbalwinder
Copy link
Contributor

I am testing this on Deception GPUs manually. Once all our tests pass, I will manually merge this branch.

@singhbalwinder
Copy link
Contributor

All tests passed on deception:

100% tests passed, 0 tests failed out of 573

Total Test time (real) = 217.22 sec

@singhbalwinder singhbalwinder merged commit 5495c27 into eagles-project:main Jul 19, 2024
4 of 6 checks passed
@mahf708
Copy link
Contributor Author

mahf708 commented Jul 19, 2024

Thanks @singhbalwinder! Maybe we can rebase E3SM-Project/scream#2911 now to retest on mappy/weaver?

@mahf708 mahf708 deleted the fix-compile-errors branch July 19, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhbalwinder singhbalwinder singhbalwinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahf708 @singhbalwinder