fix(ebay-table): update row-header attribute, removed aria-pressed #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 96b0ae6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was
linked to
issues
Jan 17, 2025
agliga
reviewed
Jan 17, 2025
| @@ -73,9 +74,7 @@ $ const { | |||
| sortEleAttr = { href }; | |||
| } else if (sortOrder) { | |||
| sortEleAttr = { | |||
| type: "button", | |||
There was a problem hiding this comment.
I belive we still need to add an a11y text for screen readers to know what the sort order is.
Lets chat tomorrow
agliga
force-pushed
the
2313-ebay-table-various-fixes
branch
from
b5ae6ed to
96b0ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
column-typeofrow-headerwith a booleanrow-headerin theebay-tablecomponent. Updated the relevant Marko and JSON files to reflect this change. Removed incorrectly usedaria-pressed.Context
This change was made to simplify the handling of row headers and improve ARIA accessibility. The boolean
row-headeris more intuitive and aligns better with accessibility standards.References
Tests