-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS nix fixes #2321
MacOS nix fixes #2321
Conversation
3b9947b
to
99a00eb
Compare
just a sidenote: running IMHO, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiling is fine for me as a workaround, but in general, I don't want people to compile stuff, I want to use internet-provided builds to not waste time and energy.
running pip install "psycopg[binary]" on macos works, the same is when just installing poetry, so this seems to be a poetry2nix problem.
Is there a chance we could get this fixed in poetry2nix, does it make sense to open an issue somewhere (@niklasmohrin)?
If I understood correctly it's either a mismatch between what nix and python (and different Python libraries) use as a name for arm macs, or the wheels are just missing. That being said, I recently read that nixpkgs updated and refactored the apple sdks, so I suppose I will look into this again before moving forward here |
69b36fa
to
5c3ebbe
Compare
psycopg
installation method69b36fa
to
fb7a964
Compare
@ybrnr Can you do one last check of the following?
(edit: they told me in person that it works) |
If this works, I think we will just keep it as is, because we should probably move away from poetry2nix anyways, as the maintainer stepped down a couple of days ago :/ Looks like uv2nix is the current recommendation |
With a locale like `en_US.UTF-8`, `tr` complains about invalid UTF-8 when running `cat /dev/urandom | tr ...`.
fb7a964
to
9c48a44
Compare
9c48a44
to
0be15b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also works with macos on x86_64
Mac users reported issues that boiled down to
psycopg[binary]
not having a matching wheel. I thought that using the "pure Python installation" (justpsycopg
) would work, but this breaks even on Linux as the libpq dynamic library cannot be found (even when adding postgres to the nix shell packages or the build inputs of the Python packages). There is alsopsycopg[c]
which compiles the extension at installation time. This seems to work and the compilation time is not too long either (on a Surface from this decade it took ~1min to compile the extension, same in a Mac VM).Should we just default to using
psycopg[c]
on Linux too, or stick to using the binary installation on Linux?