WIP: JSON enrollment importer #2187
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
requested changes
Jun 24, 2024
hansegucker
force-pushed
the
json-enrollment-importer
branch
from
6f2f53a
to
cc0f045
Compare
richardebeling
requested changes
Jul 15, 2024
Comment on lines
+289
to
+295
| with TemporaryDirectory() as temp_dir: | ||
| test_filename = os.path.join(temp_dir, "test.json") | ||
| with open(test_filename, "w", encoding="utf-8") as f: | ||
| f.write(EXAMPLE_JSON) | ||
| call_command("json_import", self.semester.id, test_filename, stdout=output) | ||
|
|
||
| mock_import_json.assert_called_once_with(EXAMPLE_JSON) |
There was a problem hiding this comment.
I'd rather not make this physically go to disk, there is so much that can go wrong here (read-only filesystem, we may leave garbage on the disk, ...).
Can we just mock away all the filesystem access here?
janno42
requested changes
Jul 29, 2024
|
If possible, we should remove the debug info text from the log email |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.