Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survey Assist Using RF #938
base: master
Are you sure you want to change the base?
Survey Assist Using RF #938
Changes from 3 commits
6471a96
9d6a1af
9bd9b18
1b9ece0
e7d2a14
59633e0
0adb5fe
e9abd51
3820d87
5b2572e
bf7f406
1d7be5a
b3d0db2
c514fe0
3b038a9
94fc848
87f109c
33cdaab
01fcb2a
f5fec64
585cc90
61bbe3f
a32ce4f
052cb08
104dd9a
1b523ed
35a1346
19bb394
450094c
ad968de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this file is currently unused, it is certainly not tested. Is there a reason we need to include it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is not needed. The file
dbscan_svm.py
file was created before we moved all models related code frome-mission-eval-private-data
. After moving, this code is already present inmodels.py
. Will remove this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this file is currently unused since it is not tested. We don't want to check in vestigial code; it will just eventually bitrot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Unused and shouldn't be included. Removing.