Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the trip confirm screen to also go to the diary directly #754

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

shankari
Copy link
Contributor

Avoids race conditions and confusion; highlights the diary
We may want to merge this to master based on feedback from the CEO project

Avoids race conditions and confusion; highlights the diary
We may want to merge this to master based on feedback from the CEO project
@shankari
Copy link
Contributor Author

This fixes e-mission/e-mission-docs#575

Testing done:

  • applied this change
  • started a trip
  • ended the trip
  • the diary screen loaded

@shankari shankari merged commit 3caed98 into e-mission:master Apr 15, 2021
@shankari shankari deleted the go_to_diary_always branch April 15, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant