Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support join URLs to generate OPcodes on phone, Fix URL scheme, "Paste" improvements #1187

Merged
merged 9 commits into from
Oct 23, 2024

add tests for opcode.ts

ee85fb0
Select commit
Loading
Failed to load commit list.
Merged

Support join URLs to generate OPcodes on phone, Fix URL scheme, "Paste" improvements #1187

add tests for opcode.ts
ee85fb0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 17, 2024 in 1s

29.98% (+0.56%) compared to d4986e9

View this Pull Request on Codecov

29.98% (+0.56%) compared to d4986e9

Details

Codecov Report

Attention: Patch coverage is 70.47619% with 31 lines in your changes missing coverage. Please review.

Project coverage is 29.98%. Comparing base (d4986e9) to head (ee85fb0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
www/js/onboarding/WelcomePage.tsx 0.00% 18 Missing ⚠️
www/js/App.tsx 0.00% 5 Missing ⚠️
www/js/config/dynamicConfig.ts 80.00% 3 Missing ⚠️
www/js/components/QrCode.tsx 0.00% 2 Missing ⚠️
www/js/control/PopOpCode.tsx 0.00% 2 Missing ⚠️
www/js/config/opcode.ts 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
+ Coverage   29.41%   29.98%   +0.56%     
==========================================
  Files         122      123       +1     
  Lines        4919     4933      +14     
  Branches     1125     1091      -34     
==========================================
+ Hits         1447     1479      +32     
+ Misses       3470     3454      -16     
+ Partials        2        0       -2     
Files with missing lines Coverage Δ
www/js/components/AlertBar.tsx 6.25% <ø> (ø)
www/js/control/ProfileSettings.tsx 0.00% <ø> (ø)
www/js/config/opcode.ts 98.41% <98.41%> (ø)
www/js/components/QrCode.tsx 0.00% <0.00%> (ø)
www/js/control/PopOpCode.tsx 0.00% <0.00%> (ø)
www/js/config/dynamicConfig.ts 86.79% <80.00%> (+1.47%) ⬆️
www/js/App.tsx 0.00% <0.00%> (ø)
www/js/onboarding/WelcomePage.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes