-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes for setup_native.sh #1180
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
=======================================
Coverage 30.14% 30.14%
=======================================
Files 118 118
Lines 5172 5172
Branches 1110 1158 +48
=======================================
Hits 1559 1559
+ Misses 3611 3609 -2
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest simplifying further and just always installing both iOS and android dependencies. We can also unify the two separate CI/CD builds into one - e.g. osx-native-install
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And I can test it out now on my new laptop as well!
In e-mission#1180 we unified the setup scripts so that we don't have separate android and iOS setup. This is because the plugins include both, so installing the plugins will fail unless the dependencies are installed, which, in turn, depends on having cocoapods installed 6dd71f1 fixed all the other github action scripts, but left this one out since it wasn't triggered
The current setup script does not allow only performing a setup for ios or android. This change would fix that by just requiring them to be explicitly set instead of trying to do them both if none are set.
The script now requires brew if the correct ruby installation is not found, regardless of OSX version.