Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused survey-resources directory #1178

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

JGreenlee
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.13%. Comparing base (3b6ecd5) to head (636b239).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1178   +/-   ##
=======================================
  Coverage   30.13%   30.13%           
=======================================
  Files         118      118           
  Lines        5164     5164           
  Branches     1108     1157   +49     
=======================================
  Hits         1556     1556           
+ Misses       3606     3604    -2     
- Partials        2        4    +2     
Flag Coverage Δ
unit 30.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@JGreenlee JGreenlee merged commit ac5fb28 into e-mission:master Sep 12, 2024
8 checks passed
@shankari
Copy link
Contributor

🥳 Yay for your first merge to master, exercising that write access!! 🎉

@shankari
Copy link
Contributor

@JGreenlee now that this is removed, I don't think we have a copy of the default demographic survey in editable (xls) form anywhere. Could we check in the editable versions somewhere so that people who want to customize the survey(s) can find them?

@JGreenlee
Copy link
Collaborator Author

We do have them checked into nrel-openpath-deploy-configs, but they are only on the surveys-info-and-surveys-data branch.
https://github.com/e-mission/nrel-openpath-deploy-configs/tree/surveys-info-and-surveys-data/survey-resources/data-xls

I think we ought to PR those files from surveys-info-and-surveys-data so they don't get lost or forgotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants