Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to debug issues with draft trips #1175

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

JGreenlee
Copy link
Collaborator

Add log statement to debug filtered unprocessed trips

add InspectableWebview = true to making debugging in production easier

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.13%. Comparing base (3b6ecd5) to head (ed3ea1c).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
www/js/diary/timelineHelper.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   30.13%   30.13%           
=======================================
  Files         118      118           
  Lines        5164     5167    +3     
  Branches     1108     1109    +1     
=======================================
+ Hits         1556     1557    +1     
- Misses       3606     3608    +2     
  Partials        2        2           
Flag Coverage Δ
unit 30.13% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
www/js/diary/timelineHelper.ts 91.26% <66.66%> (-0.70%) ⬇️

@shankari shankari merged commit b426c9a into e-mission:master Sep 12, 2024
8 checks passed
@shankari
Copy link
Contributor

shankari commented Sep 13, 2024

@JGreenlee I have pulled this and rebuilt, but I don't think that the best option is to push it to staging, because the staging version is typically compiled with production webpack so I think you won't be able to connect to it anyway. I have uploaded an app zip here; you can download and test in the simulator with the fake locations.

If you would like to test differently, let me know what you would like me to do to generate a debug build for you to use.

@JGreenlee
Copy link
Collaborator Author

JGreenlee commented Sep 13, 2024

@shankari
Since it seems to only affect draft trips recorded on the phone, but not yet pushed to the server, I don't think that the Simulator will be of any help, unless you know a way to mock a trip on the Simulator.
I was hoping to just reproduce the issue on a test iPhone.

I still think that having these changes on staging will help me debug. Besides inspectability, there is a new log statement allowing me to view draft trips that are being filtered (which prior logs indicated was the case)

And although staging has Webpack-minified JS, the log statements will still be there to tell me where I am in the code and there's a chance I might find something that way. I have debugged minified JS before. (Remember when we had that Angular annotations bug that only affected prod?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants