🐛 Fix agg metrics, don't use "for .. in .." on JS arrays #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agg metrics were broken because we iterated over an array using "for .. in ..", which has unexpected consequences. "for .. in .." iterates over all the keys in an object. Arrays are a type of object, where the elements of the array are keyed by index. But they can have other properties too (like their methods) so when you use "for .. in .." you get everything. In general arrays should be iterated with "for .. of .." or ".forEach", but in this specific case I noticed we are basically just copying an array with some values substituted, so I opted for ".map". Note: There is repeated code across these two files that should obviously be refactored later, but for now I just want to get this bug fixed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 30.09% 30.10% +0.01%
==========================================
Files 118 118
Lines 5203 5201 -2
Branches 1113 1162 +49
==========================================
Hits 1566 1566
+ Misses 3635 3631 -4
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
By the way, the reason this issue emerged out of the blue was a bug in Transcrypt. Although using "for .. in .." on an array is less than ideal, the code was working fine like that for several releases – until we added e-mission-common which includes Transcrypt. I submitted a PR to Transcrypt that would address this: |
shankari
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agg metrics were broken because we iterated over an array using "for .. in ..", which has unexpected consequences.
"for .. in .." iterates over all the keys in an object. Arrays are a type of object, where the elements of the array are keyed by index. But they can have other properties too (like their methods) so when you use "for .. in .." you get everything.
In general arrays should be iterated with "for .. of .." or ".forEach", but in this specific case I noticed we are basically just copying an array with some values substituted, so I opted for ".map".
Note: There is repeated code across these two files that should obviously be refactored later