💩 Turn off the background checks for fleet deployments #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the fleet deployments are installed on work phones, and the background restriction is apparently grayed out on android work phones. e-mission/e-mission-docs#1070 This is a hack (hence the 💩 emoji) but it will allow us to make progress through the onboarding, get the logs and then resolve the issue the right way. Or if we can't figure out how to access it the right way, this can become a config option for deployments that plan to use work phones. This should unblock e-mission/e-mission-docs#1070 (comment)
…ed_app_check_for_android_fermata
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
- Coverage 26.42% 26.40% -0.02%
==========================================
Files 114 114
Lines 4980 4983 +3
Branches 1062 1064 +2
==========================================
Hits 1316 1316
- Misses 3662 3665 +3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
shankari
force-pushed
the
hack_to_disable_unused_app_check_for_android_fermata
branch
from
2bf1aab to
0ec199b
Compare
In the previous commit, we had disabled all android background checks. This means that the optimization check would also be disabled, and we would not be able to start the foreground service from the background. Let's change this to only disable to unused apps check
shankari
force-pushed
the
hack_to_disable_unused_app_check_for_android_fermata
branch
from
0ec199b to
9921c52
Compare
|
There are no current unit tests for the permission screen. I am going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the fleet deployments are installed on work phones, and the background restriction is apparently grayed out on android work phones.
e-mission/e-mission-docs#1070
This is a hack (hence the 💩 emoji) but it will allow us to make progress through the onboarding, get the logs and then resolve the issue the right way. Or if we can't figure out how to access it the right way, this can become a config option for deployments that plan to use work phones.
This should unblock
e-mission/e-mission-docs#1070 (comment)