Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock React version to ~18.2.0 #1148

Merged
merged 10 commits into from
Apr 28, 2024
Merged

Lock React version to ~18.2.0 #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a335ad3
lock React version to ~18.2.0
JGreenlee Apr 26, 2024
d43d293
💩 Temporarily pin the version to 14.1 so that the CI is successful
shankari Apr 26, 2024
379bb76
💩 Revert back even further to xcode 14
shankari Apr 26, 2024
e81adf9
📌 Ensure that we are using the correct version of java
shankari Apr 26, 2024
2255909
🔧 Change the environment variable to the one used in the new github a…
shankari Apr 28, 2024
b5072f3
📌 Pin the mac version to 13
shankari Apr 28, 2024
0d0b212
📌 Pin the mac version to 13
shankari Apr 28, 2024
02abd93
⏪️ Revert previous attempts to fix the issue
shankari Apr 28, 2024
08dca5a
📌 Pin the xcode version again
shankari Apr 28, 2024
d188a78
Ensure that the switch command is run as root
shankari Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/android-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,17 @@ jobs:
# This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
runs-on: macos-latest
runs-on: macos-13

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2

# Runs a single command using the runners shell
- name: Prints related environment variables so that we can know what to set
run: env | egrep "JAVA|PATH|ANDROID"

# Runs a single command using the runners shell
- name: Print the java and gradle versions
run: |
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/ios-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
runs-on: macos-latest
runs-on: macos-13

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand All @@ -33,6 +33,12 @@ jobs:
- name: Print the xcode path
run: xcode-select --print-path

- name: Set xcode to 14.1
run: |
sudo xcode-select --switch /Applications/Xcode_14.1.app
echo "After setting xcode version "`xcode-select --print-path`
- name: Print the xcode setup
run: xcodebuild -version -sdk

Expand Down
6 changes: 3 additions & 3 deletions package.cordovabuild.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@babel/preset-typescript": "^7.21.4",
"@ionic/cli": "6.20.8",
"@types/luxon": "^3.3.0",
"@types/react": "^18.2.20",
"@types/react": "~18.2.0",
"babel-loader": "^9.1.2",
"babel-plugin-optional-require": "^0.3.1",
"concurrently": "^8.0.1",
Expand Down Expand Up @@ -152,9 +152,9 @@
"npm": "^9.6.3",
"phonegap-plugin-barcodescanner": "git+https://github.com/phonegap/phonegap-plugin-barcodescanner#v8.1.0",
"prop-types": "^15.8.1",
"react": "^18.2.*",
"react": "~18.2.0",
"react-chartjs-2": "^5.2.0",
"react-dom": "^18.2.*",
"react-dom": "~18.2.0",
"react-i18next": "^13.5.0",
"react-native-paper": "^5.11.0",
"react-native-paper-dates": "^0.18.12",
Expand Down
7 changes: 4 additions & 3 deletions package.serve.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@ionic/cli": "6.20.8",
"@testing-library/react-native": "^12.3.0",
"@types/luxon": "^3.3.0",
"@types/react": "^18.2.20",
"@types/react": "~18.2.0",
"babel-jest": "^29.7.0",
"babel-loader": "^9.1.2",
"babel-plugin-optional-require": "^0.3.1",
Expand All @@ -40,6 +40,7 @@
"jest-environment-jsdom": "^29.7.0",
"phonegap": "9.0.0+cordova.9.0.0",
"process": "^0.11.10",
"react-test-renderer": "~18.2.0",
"sass": "^1.62.1",
"sass-loader": "^13.3.1",
"style-loader": "^3.3.3",
Expand Down Expand Up @@ -76,9 +77,9 @@
"luxon": "^3.3.0",
"npm": "^9.6.3",
"prop-types": "^15.8.1",
"react": "^18.2.*",
"react": "~18.2.0",
"react-chartjs-2": "^5.2.0",
"react-dom": "^18.2.*",
"react-dom": "~18.2.0",
"react-i18next": "^13.5.0",
"react-native-paper": "^5.11.0",
"react-native-paper-dates": "^0.18.12",
Expand Down
Loading