-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔵🦷 UI changes for BLE integration #1145
Merged
+510
−173
Merged
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
26c388d
📋 Prep for saving new BLE Bluetooth objects
shankari 5f53e53
include 'sections' in UnprocessedTrips
JGreenlee 76d1131
update types relating to `UnprocessedTrip`s
JGreenlee 12db91a
rename functions related to unprocessed trips
JGreenlee 826190a
flesh out more types
JGreenlee ba3ef43
Fill in a "beacons" array for the range callback
shankari 6ca810d
Prettier fixes + highlight that the buttons simulate behavior
shankari 7cb3882
✨ Simulate BLE entries and transitions through the UI
shankari 2cc07a0
add type defs for BLE data + new config fields
JGreenlee a586bb7
retrieve + match BLE scans to timelineEntries
JGreenlee bff97ae
use labels OR bluetooth vehicle identity to determine "confirmed mode"
JGreenlee 463c2a5
🤡 Switch the simulation code in the UI to use the mock objects
shankari fbedee4
during bluetooth_ble matching, convert major and minor to hexadecimal
JGreenlee 3fd2863
add "Refresh App Configuration" row to Profile tab
JGreenlee d61a4af
Merge branch 'simulate_ble_scans' of https://github.com/shankari/e-mi…
JGreenlee 8de3ca0
Merge branch 'unprocessed-trip-sections' of https://github.com/JGreen…
JGreenlee 6cd4e6b
allow android emulator to download locally hosted configs by using 10…
JGreenlee 933f9a4
CSP allow 10.0.2.2 for android emulator
JGreenlee fcaec5c
fix typo: "background_ble" -> "bluetooth_ble"
JGreenlee b2d22b7
revert "CSP allow 10.0.2.2 for android emulator"
JGreenlee 0b6b844
add "confirmedMode" to derived properties & use for conditional surveys
JGreenlee 37fbb85
only use "ranging" scans for BLE matching
JGreenlee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add this, we should also add
http://localhost:9090
. Although I really don't think we should change this in theindex.html
since it can be a (very farfetched) security hole in production. Ideally, we would add these (and theedit-config
tag inconfig.xml
as part ofnpm run build-dev
and remove them as part ofnpm build
.For now, I have the changes implemented locally to allow testing but have not checked them in.
I also made https://github.com/e-mission/e-mission-phone/pull/1145/files#diff-d7df3a5aedf99d611872de9affe54d6bd62531488711022ee9f33d1ac86baab6R148 locally but didn't check it in 😄